fix(db): comprehensive symbol recovery + safety fixes

prisma/migrate.js

@@ -2,6 +2,12 @@
  * Database migration script using PrismaClient raw SQL.
  * Does NOT require the Prisma CLI (npx prisma) — only the runtime client.
  * Safe to run multiple times (all statements are idempotent).
+ *
+ * SAFETY RULES:
+ * - NO deleteMany / DELETE / TRUNCATE on icon_assets, icon_categories,
+ *   tenant_symbols, or features. These contain user data.
+ * - All operations must be idempotent (safe to re-run).
+ * - In production, destructive operations are blocked.
  */
 const { PrismaClient } = require('@prisma/client')
 
@@ -121,10 +127,9 @@ async function migrate() {
     await prisma.$executeRawUnsafe(`UPDATE tenants SET "subscriptionStatus" = 'ACTIVE' WHERE "subscriptionStatus" = 'TRIAL'`)
   } catch (e) { /* ignore */ }
 
-  // ─── Step 6: Clean up orphan users ───
-  console.log('  [6/7] Cleaning up orphan users...')
+  // ─── Step 6: Detect orphan users (log only, no deletion) ───
+  console.log('  [6/7] Checking for orphan users...')
   try {
-    // Find users who are NOT SERVER_ADMIN and have NO tenant membership
     const orphans = await prisma.user.findMany({
       where: {
         role: { not: 'SERVER_ADMIN' },
@@ -133,22 +138,15 @@ async function migrate() {
       select: { id: true, email: true, name: true },
     })
     if (orphans.length > 0) {
-      console.log(`  Found ${orphans.length} orphan user(s):`)
+      console.log(`  ⚠️  Found ${orphans.length} orphan user(s) (NOT deleting — manual review required):`)
       for (const o of orphans) {
         console.log(`    - ${o.email} (${o.name})`)
       }
-      // Delete orphan users and their related data
-      await prisma.user.deleteMany({
-        where: {
-          id: { in: orphans.map(o => o.id) },
-        },
-      })
-      console.log(`  🗑️  ${orphans.length} orphan user(s) removed`)
     } else {
       console.log('  No orphan users found')
     }
   } catch (e) {
-    console.log('  Orphan cleanup skipped:', e.message)
+    console.log('  Orphan check skipped:', e.message)
   }
 
   // ─── Step 7: Backfill logoFileKey from logoUrl ───
@@ -222,7 +220,7 @@ async function migrate() {
         id TEXT PRIMARY KEY DEFAULT gen_random_uuid(),
         "isActive" BOOLEAN NOT NULL DEFAULT true,
         "tenantId" TEXT NOT NULL REFERENCES tenants(id) ON DELETE CASCADE,
-        "iconId" TEXT NOT NULL REFERENCES icon_assets(id) ON DELETE CASCADE,
+        "iconId" TEXT REFERENCES icon_assets(id) ON DELETE SET NULL,
         UNIQUE("tenantId", "iconId")
       )
     `)
@@ -290,6 +288,39 @@ async function migrate() {
   }
   console.log(`  ${tsAdded}/${tenantSymbolColumns.length} tenant_symbol columns added`)
 
+  // ─── Step 16: Fix tenant_symbols FK (CASCADE → SET NULL) ───
+  console.log('  [16] Fixing tenant_symbols.iconId FK (CASCADE → SET NULL)...')
+  try {
+    // Make iconId nullable
+    await prisma.$executeRawUnsafe(`ALTER TABLE tenant_symbols ALTER COLUMN "iconId" DROP NOT NULL`)
+    // Drop old cascade FK and recreate with SET NULL
+    await prisma.$executeRawUnsafe(`
+      DO $$ BEGIN
+        -- Drop existing FK constraint (name varies)
+        ALTER TABLE tenant_symbols DROP CONSTRAINT IF EXISTS "tenant_symbols_iconId_fkey";
+        ALTER TABLE tenant_symbols DROP CONSTRAINT IF EXISTS "tenant_symbols_iconId_icon_assets_id_fk";
+        -- Recreate with SET NULL
+        ALTER TABLE tenant_symbols
+          ADD CONSTRAINT "tenant_symbols_iconId_fkey"
+          FOREIGN KEY ("iconId") REFERENCES icon_assets(id) ON DELETE SET NULL;
+      EXCEPTION WHEN OTHERS THEN
+        RAISE NOTICE 'FK fix skipped: %', SQLERRM;
+      END $$;
+    `)
+    console.log('  ✅ tenant_symbols.iconId FK is now ON DELETE SET NULL')
+  } catch (e) {
+    console.log('  FK fix skipped:', e.message)
+  }
+
+  // ─── Step 17: Drop unique constraint on tenant_symbols(tenantId, iconId) ───
+  console.log('  [17] Dropping UNIQUE(tenantId, iconId) on tenant_symbols...')
+  try {
+    await prisma.$executeRawUnsafe(`ALTER TABLE tenant_symbols DROP CONSTRAINT IF EXISTS "tenant_symbols_tenantId_iconId_key"`)
+    console.log('  ✅ Unique constraint dropped (duplicates now allowed)')
+  } catch (e) {
+    console.log('  Unique constraint drop skipped:', e.message)
+  }
+
   console.log('✅ Database migrations complete')
 }